[Nasm-bugs] [Bug 3392464] New: inverted ifdef condition for unlikely_func

no-reply at bugzilla-nasm.gorcunov.org no-reply at bugzilla-nasm.gorcunov.org
Thu Feb 22 22:57:44 PST 2018


https://bugzilla.nasm.us/show_bug.cgi?id=3392464

            Bug ID: 3392464
           Summary: inverted ifdef condition for unlikely_func
           Product: NASM
           Version: 2.14 (development)
          Hardware: All
                OS: All
            Status: OPEN
          Severity: normal
          Priority: Medium
         Component: Assembler
          Assignee: nobody at nasm.us
          Reporter: sezeroz at gmail.com
                CC: gorcunov at gmail.com, hpa at zytor.com, nasm-bugs at nasm.us
     Obtained from: Built from git using configure

Fix typo added in commit 6686fc6 :

diff --git a/include/compiler.h b/include/compiler.h
index aba773e7..fb146af4 100644
--- a/include/compiler.h
+++ b/include/compiler.h
@@ -296,7 +296,7 @@ size_t strnlen(const char *s, size_t maxlen);
  * This differs from unlikely() in that it is applied to a function call,
  * not a boolean condition.
  */
-#ifndef HAVE_FUNC_ATTRIBUTE_COLD
+#ifdef HAVE_FUNC_ATTRIBUTE_COLD
 # define unlikely_func __attribute__((cold))
 #else
 # define unlikely_func

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.


More information about the Nasm-bugs mailing list