[Nasm-bugs] [Bug 3392471] New: configury PA_ADD_HEADERS bug

[no-reply at bugzilla-nasm.gorcunov.org]

https://bugzilla.nasm.us/show_bug.cgi?id=3392471

            Bug ID: 3392471
           Summary: configury PA_ADD_HEADERS bug
           Product: NASM
           Version: 2.14 (development)
          Hardware: All
                OS: All
            Status: OPEN
          Severity: normal
          Priority: Medium
         Component: Assembler
          Assignee: nobody at nasm.us
          Reporter: sezeroz at gmail.com
                CC: gorcunov at gmail.com, hpa at zytor.com, nasm-bugs at nasm.us
     Obtained from: Built from git using configure

nasm configury generates a bad configure script with development
versions of autoconf.  Basically what happens is this, configure
generated with autoconf-2.69 vs. autoconf-git:

-done
-for ac_header in sys/endian.h
+donefor ac_header in sys/endian.h
[...]
-done
-for ac_header in machine/endian.h
+donefor ac_header in machine/endian.h

And as a result, the generated configure fails to run.

I asked this at bug-autoconf [1], and Paul Eggert said that this is
a bug in nasm configury where there should be a newline in the SEP
argument of m4_map_args_w in the PA_ADD_HEADERS macro [2].  Indeed,
the following change fixes the issue:

diff --git a/aclocal.m4 b/aclocal.m4
index 36d36cf..84e8e86 100644
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -171,7 +171,8 @@ AC_DEFUN(_PA_ADD_HEADER,
 ])])

 AC_DEFUN(PA_ADD_HEADERS,
-[m4_map_args_w([$1],[_PA_ADD_HEADER(],[)])])
+[m4_map_args_w([$1],[_PA_ADD_HEADER(],[)
+])])

 dnl --------------------------------------------------------------------------
 dnl PA_CHECK_BAD_STDC_INLINE


P.S.: There is another issue with using development versions of
autoconf: the generated configure script wants to run config.guess
and config.sub, but autogen.sh doesn't add them:
[...]
checking for fileno... yes
checking for _fileno... no
checking for _filelengthi64... no
configure: error: cannot run /bin/sh ./config.sub

Adding them manually makes it run properly.

[1] http://lists.gnu.org/archive/html/bug-autoconf/2018-03/msg00000.html
[2] http://lists.gnu.org/archive/html/bug-autoconf/2018-03/msg00001.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.