[Nasm-bugs] [Bug 3392648] New: -I$(srcdir)/asm in NASM's Makefile causes the code to not compile on Haiku

noreply-nasm at dev.nasm.us noreply-nasm at dev.nasm.us
Thu Jan 23 10:33:11 PST 2020


https://bugzilla.nasm.us/show_bug.cgi?id=3392648

            Bug ID: 3392648
           Summary: -I$(srcdir)/asm in NASM's Makefile causes the code to
                    not compile on Haiku
           Product: NASM
           Version: unspecified
          Hardware: All
                OS: Other Unix
            Status: OPEN
          Severity: normal
          Priority: Medium
         Component: Assembler
          Assignee: nobody at nasm.us
          Reporter: alaviss0+nasm at gmail.com
                CC: chang.seok.bae at intel.com, gorcunov at gmail.com,
                    hpa at zytor.com, nasm-bugs at nasm.us
     Obtained from: Build from source archive using configure, Built from
                    git using configure

Created attachment 411758
  --> https://bugzilla.nasm.us/attachment.cgi?id=411758&action=edit
Makefile.in: use iquote for include paths

Haiku's <limits.h> includes C stdlib's <float.h>, which was overridden by
NASM's float.h, causing hard to trace compilation failures. Given that NASM
uses quoted includes for internal headers, there aren't any need for using -I,
which adds a path to both quoted include search path and system include search
path[0].

Attached is a patch that swap out -I for -iquote, in order to not unnecessary
overrides system include path.

[0]:
https://gcc.gnu.org/onlinedocs/gcc-7.5.0/gcc/Directory-Options.html#Directory-Options

-- 
You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.


More information about the Nasm-bugs mailing list