[Nasm-bugs] [Bug 3392662] nasm-2.15rc1 breaks firefox build (possibly related to 3392652?)

noreply-nasm at dev.nasm.us noreply-nasm at dev.nasm.us
Tue Jun 9 13:05:14 PDT 2020


Henrik <henrik at gramner.com> changed:

           What    |Removed                     |Added
                 CC|                            |henrik at gramner.com

--- Comment #14 from Henrik <henrik at gramner.com> ---
(In reply to H. Peter Anvin from comment #12)
> OK, so this one is the opposite of the x264 problem... it wants to be able
> to call the macro defined as 6-7 with a terminal comma, which is really an
> 8th argument.
> I guess the fallback matching needs another subcase.

FWIW the problematic code in question (specifically, in a 3rd party component
of Firefox) has been fixed upstream now.

Prior versions of nasm were just very lenient about parsing macro arguments and
happily accepted it without warning making it go undetected, so it's possible
similar issues may pop up in other codebases. I guess making it a warning
instead of an error would be ideal if it's not too much effort involved.

You are receiving this mail because:
You are watching all bug changes.
You are on the CC list for the bug.

More information about the Nasm-bugs mailing list