[Nasm-bugs] [Bug 3392649] ndisasm should read stdin in binary mode in stead of text mode

noreply-nasm at dev.nasm.us noreply-nasm at dev.nasm.us
Wed May 6 15:57:37 PDT 2020


Chang S. Bae <chang.seok.bae at intel.com> changed:

           What    |Removed                     |Added
             Status|OPEN                        |CLOSED
         Resolution|---                         |FIXED

--- Comment #2 from Chang S. Bae <chang.seok.bae at intel.com> ---
The below commit should have resolved the issue:

commit  bd1055b8be048c4b996415a0438f8b48ac766f90
author  Chang S. Bae <chang.seok.bae at intel.com> 
Tue, 24 Mar 2020 21:24:43 +0000 (24 14:24 -0700)
committer       Chang S. Bae <chang.seok.bae at intel.com> 
Wed, 22 Apr 2020 00:09:58 +0000 (22 00:09 +0000)

The binary mode has no difference from text mode in
POSIX-compliant operating systems. The two modes are
distinguishable from each other on Windows, and perhaps
on other systems as well.

The binary stream has scalability and other advantages.
Windows treats the standard input stream as text mode by
default. So the code changes it to binary mode.

Also, add a helper function, nasm_set_binary_mode(),
that is OS-agnostic, in the library.

You are receiving this mail because:
You are on the CC list for the bug.
You are watching all bug changes.

More information about the Nasm-bugs mailing list