[nasm:nasm-2.15.xx] outobj: limit excessive length warning to 64 characters

nasm-bot for H. Peter Anvin hpa at zytor.com
Tue Aug 18 12:36:03 PDT 2020


Commit-ID:  4a2c8c52c7f96ee9f8932ea4a94b243006d30711
Gitweb:     http://repo.or.cz/w/nasm.git?a=commitdiff;h=4a2c8c52c7f96ee9f8932ea4a94b243006d30711
Author:     H. Peter Anvin <hpa at zytor.com>
AuthorDate: Tue, 18 Aug 2020 12:31:10 -0700
Committer:  H. Peter Anvin <hpa at zytor.com>
CommitDate: Tue, 18 Aug 2020 12:33:51 -0700

outobj: limit excessive length warning to 64 characters

The case where we warn for excessive length should presumably have
been %.nnns which means limit length to nnn characters, rather than
%nnns which means left-pad with spaces to nnn bytes if possible. Also
change the limit from 128 to 64, to make it more likely to not line
break.

Cc: Cyrill Gorcunov <gorcunov at gmail.com>
Signed-off-by: H. Peter Anvin (Intel) <hpa at zytor.com>


---
 output/outobj.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/output/outobj.c b/output/outobj.c
index f5ab7a24..ca5b27c7 100644
--- a/output/outobj.c
+++ b/output/outobj.c
@@ -425,7 +425,7 @@ static ObjRecord *obj_name(ObjRecord * orp, const char *name)
     uint8_t *ptr;
 
     if (len > UINT8_MAX) {
-        nasm_warn(WARN_OTHER, "cutting object name '%128s...' to %u bytes",
+        nasm_warn(WARN_OTHER, "cutting object name `%.64s...' to %u bytes",
                   name, UINT8_MAX);
         len = UINT8_MAX;
     }


More information about the Nasm-commits mailing list