[Nasm-commits] [nasm:nasm-2.15.xx] outobj: fix harmless but still incorrect use of uninitialized variable

nasm-bot for H. Peter Anvin hpa at zytor.com
Thu Jun 4 19:57:01 PDT 2020


Commit-ID:  a3cbaafd523229b98527a6ae07ec8b6acd06b57d
Gitweb:     http://repo.or.cz/w/nasm.git?a=commitdiff;h=a3cbaafd523229b98527a6ae07ec8b6acd06b57d
Author:     H. Peter Anvin <hpa at zytor.com>
AuthorDate: Mon, 1 Jun 2020 16:11:47 -0700
Committer:  H. Peter Anvin <hpa at zytor.com>
CommitDate: Mon, 1 Jun 2020 16:11:47 -0700

outobj: fix harmless but still incorrect use of uninitialized variable

Fix use of uninitialized variable. This most likely is just an
issue while running at debug level >= 3, but it's still wrong.

Signed-off-by: H. Peter Anvin (Intel) <hpa at zytor.com>


---
 output/outobj.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/output/outobj.c b/output/outobj.c
index 9d5e4b6a..0d4d3110 100644
--- a/output/outobj.c
+++ b/output/outobj.c
@@ -833,7 +833,7 @@ static void obj_deflabel(char *name, int32_t segment,
      * `first_seg'.
      */
     if (!any_segs && segment == first_seg) {
-        int tempint;            /* ignored */
+        int tempint = 0;
         if (segment != obj_segment("__NASMDEFSEG", &tempint))
             nasm_panic("strange segment conditions in OBJ driver");
     }
@@ -1025,7 +1025,7 @@ static void obj_out(int32_t segto, const void *data,
      * segment.
      */
     if (!any_segs) {
-        int tempint;            /* ignored */
+        int tempint = 0;
         if (segto != obj_segment("__NASMDEFSEG", &tempint))
             nasm_panic("strange segment conditions in OBJ driver");
     }
@@ -2498,7 +2498,7 @@ static void dbgbi_linnum(const char *lnfname, int32_t lineno, int32_t segto)
      * segment.
      */
     if (!any_segs) {
-        int tempint;            /* ignored */
+        int tempint = 0;
         if (segto != obj_segment("__NASMDEFSEG", &tempint))
             nasm_panic("strange segment conditions in OBJ driver");
     }


More information about the Nasm-commits mailing list