[Nasm-commits] [nasm:nasm-2.15.xx] preproc: don't call nasm_error_hold_push() twice

nasm-bot for H. Peter Anvin (Intel) hpa at zytor.com
Thu Jun 4 19:57:04 PDT 2020


Commit-ID:  c44709c964fe3ebccb63eeea6050076ad89cd333
Gitweb:     http://repo.or.cz/w/nasm.git?a=commitdiff;h=c44709c964fe3ebccb63eeea6050076ad89cd333
Author:     H. Peter Anvin (Intel) <hpa at zytor.com>
AuthorDate: Thu, 4 Jun 2020 16:19:01 -0700
Committer:  H. Peter Anvin (Intel) <hpa at zytor.com>
CommitDate: Thu, 4 Jun 2020 16:19:01 -0700

preproc: don't call nasm_error_hold_push() twice

We must not call nasm_error_hold_push() twice... the obvious
leak of the error stack caused all kinds of errors to be suppressed.

Signed-off-by: H. Peter Anvin (Intel) <hpa at zytor.com>


---
 asm/preproc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/asm/preproc.c b/asm/preproc.c
index 82b3825e..83a61b42 100644
--- a/asm/preproc.c
+++ b/asm/preproc.c
@@ -5491,7 +5491,6 @@ static Token *expand_smacro_noreset(Token *org_tline)
             }
         };
         Token **tail = &tline;
-        errhold = nasm_error_hold_push();
 
         /*
          * We hold warnings/errors until we are done this this loop. It is


More information about the Nasm-commits mailing list