[nasm:master] outmacho: macho_dbg_linenum -- fix memory leak

nasm-bot for Cyrill Gorcunov gorcunov at gmail.com
Sun Oct 4 14:24:04 PDT 2020


Commit-ID:  19ab41466bdfa3df188228d734f58f77cb525400
Gitweb:     http://repo.or.cz/w/nasm.git?a=commitdiff;h=19ab41466bdfa3df188228d734f58f77cb525400
Author:     Cyrill Gorcunov <gorcunov at gmail.com>
AuthorDate: Mon, 5 Oct 2020 00:20:05 +0300
Committer:  Cyrill Gorcunov <gorcunov at gmail.com>
CommitDate: Mon, 5 Oct 2020 00:20:05 +0300

outmacho: macho_dbg_linenum -- fix memory leak

In 78f14ab1a63963fd302ce7ecc48b6a9df5442675 the fix
is incomplete, we should move free procedure out of
the list_for_each traverse.

CID 1432930

Signed-off-by: Cyrill Gorcunov <gorcunov at gmail.com>


---
 output/outmacho.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/output/outmacho.c b/output/outmacho.c
index 53c6fa73..d041df64 100644
--- a/output/outmacho.c
+++ b/output/outmacho.c
@@ -2137,12 +2137,13 @@ static void macho_dbg_linenum(const char *file_name, int32_t line_num, int32_t s
             }
         }
 
-        if(need_new_list) {
+        if (need_new_list)
             new_file_list(cur_file, cur_dir);
-        } else {
+    }
+
+    if (!need_new_list) {
             nasm_free((void *)cur_file);
             nasm_free((void *)cur_dir);
-        }
     }
 
     dbg_immcall = true;


More information about the Nasm-commits mailing list